simplify configuration of oauth clients #60
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxtoacart
force-pushed
the
percy/newoauth
branch
from
864f06b to
571bc7b
Compare
oxtoacart
commented
Oct 17, 2025
client.go
Outdated
| APIKey string | ||
| // OAuthCredentials specifies credentials for authenticating with OAuth. If provided, | ||
| // APIKey is ignored. | ||
| OAuthCredentials *OAuthCredentials |
Collaborator
Author
There was a problem hiding this comment.
Combining all of the OAuth credentials into a single type so that it's just a single configuration field on the Client is nice because it avoids confusion about which combinations of fields are required for what.
oxtoacart
force-pushed
the
percy/newoauth
branch
from
571bc7b to
9f093df
Compare
oxtoacart
commented
Oct 17, 2025
client.go
Outdated
| APIKey string | ||
| // Authentication specifies a mechanism for adding authentication to outgoing requests. | ||
| // If provided, APIKey is ignored. | ||
| Authentication Authentication |
Collaborator
Author
There was a problem hiding this comment.
This is now pluggable. I'm using it for OAuth, we can also implement it for WIF, etc.
oxtoacart
force-pushed
the
percy/newoauth
branch
from
9f093df to
e261c58
Compare
OAuth can now be provided directly to the Client type. Using OAuthConfig.HTTPClient() is now deprecated. Updates tailscale/terraform-provider-tailscale#485 Signed-off-by: Percy Wegmann <[email protected]>
oxtoacart
force-pushed
the
percy/newoauth
branch
from
e261c58 to
8a62748
Compare
Collaborator
Author
|
Closing in favor of #61 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OAuthCredentials can now be provided directly to the Client type.
Using OAuthConfig.HTTPClient() is now deprecated.
Updates tailscale/terraform-provider-tailscale#485